Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(compression): allow zstd-fast algorithm #597

Merged
merged 3 commits into from
Oct 16, 2024
Merged

feat(compression): allow zstd-fast algorithm #597

merged 3 commits into from
Oct 16, 2024

Conversation

Abhinandan-Purkait
Copy link
Member

Changes in the PR

  • Adds the API changes to allow zstd-fast on regex.
  • Simpify the regex to allow stems to have selective matching.
  • Update manifests
  • Adds a new test variant for zstd-fast

Linked Issues

Fixes --> #501

@Abhinandan-Purkait
feat(compression): allow zstd-fast algorithm
37ecc88 
Signed-off-by: Abhinandan Purkait <purkaitabhinandan@gmail.com>
@Abhinandan-Purkait
test: add new entry for zstd-fast compression
c9a0113 
Signed-off-by: Abhinandan Purkait <purkaitabhinandan@gmail.com>
@Abhinandan-Purkait
chore: simplify the regex
12145af 
Signed-off-by: Abhinandan Purkait <purkaitabhinandan@gmail.com>
niladrih
niladrih approved these changes Oct 16, 2024
View reviewed changes
Copy link
Member

@niladrih niladrih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Abhinandan-Purkait
Copy link
Member Author

Update on testing:-

  1. Have tested upgrade from 2.6.1 to this and it works fine, without issues, though we would need a run from e2e as well. cc @w3aman
  2. The CI BDD test has passed with the change.

@Abhinandan-Purkait Abhinandan-Purkait self-assigned this Oct 16, 2024
@Abhinandan-Purkait Abhinandan-Purkait added this to the v4.2 milestone Oct 16, 2024
tiagolobocastro
tiagolobocastro approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@tiagolobocastro tiagolobocastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested regex and seems to work as expected, lgtm

@Abhinandan-Purkait
Copy link
Member Author

Thanks folks, merging now.

@Abhinandan-Purkait Abhinandan-Purkait merged commit 82417e7 into develop Oct 16, 2024
8 checks passed
@Abhinandan-Purkait Abhinandan-Purkait deleted the zstd-fast branch October 16, 2024 10:18
chris199512 pushed a commit to chris199512/zfs-localpv that referenced this pull request Oct 21, 2024
@Abhinandan-Purkait @chris199512
feat(compression): allow zstd-fast algorithm (openebs#597)
41b1594 
* feat(compression): allow zstd-fast algorithm

Signed-off-by: Abhinandan Purkait <purkaitabhinandan@gmail.com>

* test: add new entry for zstd-fast compression

Signed-off-by: Abhinandan Purkait <purkaitabhinandan@gmail.com>

* chore: simplify the regex

Signed-off-by: Abhinandan Purkait <purkaitabhinandan@gmail.com>

---------

Signed-off-by: Abhinandan Purkait <purkaitabhinandan@gmail.com>
Signed-off-by: chris199512 <84684730+chris199512@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niladrih niladrih niladrih approved these changes

@tiagolobocastro tiagolobocastro tiagolobocastro approved these changes

@avishnu avishnu Awaiting requested review from avishnu

@sinhaashish sinhaashish Awaiting requested review from sinhaashish

Assignees

@Abhinandan-Purkait Abhinandan-Purkait

Labels
None yet
Projects
None yet
Milestone
v4.2
Development

Successfully merging this pull request may close these issues.
3 participants
@Abhinandan-Purkait @tiagolobocastro @niladrih